X-Git-Url: http://git.kaliko.me/?a=blobdiff_plain;f=sima%2Futils%2Fconfig.py;h=d3bcbe293a1c529f10cf7fd3af04ea910cfa6eeb;hb=23309f235879380a5ef7db3a51bda4d12e31902e;hp=74c789a78dfd928120cc15dd79a7264020cff2c1;hpb=7e91245ee4c550a2eb6ba7d6735ba3d0c6760ff9;p=mpd-sima.git diff --git a/sima/utils/config.py b/sima/utils/config.py index 74c789a..d3bcbe2 100644 --- a/sima/utils/config.py +++ b/sima/utils/config.py @@ -1,5 +1,5 @@ # -*- coding: utf-8 -*- -# Copyright (c) 2009, 2010, 2011, 2013, 2014 Jack Kaliko +# Copyright (c) 2009, 2010, 2011, 2013, 2014, 2015 Jack Kaliko # # This file is part of sima # @@ -37,7 +37,7 @@ from . import utils # DEFAULTS DIRNAME = 'mpd_sima' -CONF_FILE = 'sima.cfg' +CONF_FILE = 'mpd_sima.cfg' DEFAULT_CONF = { 'MPD': { @@ -50,8 +50,9 @@ DEFAULT_CONF = { 'contrib': "", 'user_db': "false", 'history_duration': 8, - 'queue_length': 1, + 'queue_length': 2, 'var_dir': 'empty', + 'musicbrainzid': "true", }, 'daemon':{ 'daemon': False, @@ -71,6 +72,7 @@ DEFAULT_CONF = { 'track_to_add': 1, 'album_to_add': 1, 'depth': 1, + 'priority': 100, }, 'lastfm': { 'queue_mode': "track", #TODO control values @@ -80,11 +82,13 @@ DEFAULT_CONF = { 'album_to_add': 1, 'depth': 1, 'cache': True, + 'priority': 100, }, - 'randomfallback': { + 'random': { 'flavour': "sensible", # in pure, sensible 'track_to_add': 1, - } + 'priority': 50, + }, } # @@ -126,13 +130,19 @@ class ConfMan(object): # CONFIG MANAGER CLASS self.config['sima']['db_file'] = join(self.config['sima']['var_dir'], 'sima.db') def control_facc(self): - """TODO: redundant with startopt cli args controls + """Controls file access. + This is relevant only for file provided through the configuration file + since files provided on the command line are already checked with + argparse. """ ok = True for op, ftochk in [('log', self.config['log']['logfile']), ('pidfile', self.config['daemon']['pidfile']),]: if not ftochk: continue + if isdir(ftochk): + self.log.critical('Need a file not a directory: "{}"'.format(ftochk)) + ok = False if not exists(ftochk): # Is parent directory writable then filedir = dirname(ftochk) @@ -141,9 +151,11 @@ class ConfMan(object): # CONFIG MANAGER CLASS ok = False else: if not access(ftochk, W_OK): - self.log.critical('no write access to "{0}" ({1}))'.format(ftochk, op)) + self.log.critical('no write access to "{0}" ({1})'.format(ftochk, op)) ok = False if not ok: + if exists(self.conf_file): + self.log.warning('Try to check the configuration file: {}'.format(self.conf_file)) sys.exit(2) def control_mod(self): @@ -214,8 +226,8 @@ class ConfMan(object): # CONFIG MANAGER CLASS chmod(conf_dir, 0o700) self.conf_file = join(conf_dir, CONF_FILE) else: - self.log.error('Can\'t find a suitable location for config folder (XDG_CONFIG_HOME)') - self.log.error('Please use "--config" to locate the conf file') + self.log.critical('Can\'t find a suitable location for config folder (XDG_CONFIG_HOME)') + self.log.critical('Please use "--config" to locate the conf file') sys.exit(1) ## Sima sqlite DB