X-Git-Url: http://git.kaliko.me/?p=python-musicpd.git;a=blobdiff_plain;f=mpd.py;h=02d27880d35759de8ea4cc960055720804703d23;hp=be8b390482e2a18639f94298e025e2282f5400a8;hb=11ad737dbfa521db07486a6cb789d3539a5ec4c0;hpb=94fd67b7f97142bda274187e463320834a58cc15 diff --git a/mpd.py b/mpd.py index be8b390..02d2788 100644 --- a/mpd.py +++ b/mpd.py @@ -26,6 +26,9 @@ NEXT = "list_OK" class MPDError(Exception): pass +class ConnectionError(MPDError): + pass + class ProtocolError(MPDError): pass @@ -36,6 +39,13 @@ class CommandListError(MPDError): pass +class _NotConnected(object): + def __getattr__(self, attr): + return self._dummy + + def _dummy(*args): + raise ConnectionError, "Not connected" + class MPDClient(object): def __init__(self): self.iterate = False @@ -141,7 +151,10 @@ class MPDClient(object): self._writeline(" ".join(parts)) def _readline(self): - line = self._sockfile.readline().rstrip("\n") + line = self._sockfile.readline() + if not line.endswith("\n"): + raise ConnectionError, "Connection lost while reading line" + line = line.rstrip("\n") if line.startswith(ERROR_PREFIX): error = line[len(ERROR_PREFIX):].strip() raise CommandError, error @@ -259,7 +272,9 @@ class MPDClient(object): return self._wrapiterator(self._readcommandlist()) def _hello(self): - line = self._sockfile.readline().rstrip("\n") + line = self._sockfile.readline() + if not line.endswith("\n"): + raise ConnectionError, "Connection lost while reading MPD hello" if not line.startswith(HELLO_PREFIX): raise ProtocolError, "Got invalid MPD hello: '%s'" % line self.mpd_version = line[len(HELLO_PREFIX):].strip() @@ -267,12 +282,15 @@ class MPDClient(object): def _reset(self): self.mpd_version = None self._commandlist = None - self._sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - self._sockfile = self._sock.makefile("rb+") + self._sock = None + self._sockfile = _NotConnected() def connect(self, host, port): - self.disconnect() + if self._sock: + self.disconnect() + self._sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) self._sock.connect((host, port)) + self._sockfile = self._sock.makefile("rb+") self._hello() def disconnect(self):