X-Git-Url: http://git.kaliko.me/?p=python-musicpd.git;a=blobdiff_plain;f=mpd.py;h=b87891b8b93e9be559d26ac39c85f44c4ac56888;hp=380f5b1bd5426ea36c2f040820067e0a79386eb1;hb=46753bf1c1e917dee5ba9ced19fbf1f6a9c103ca;hpb=a55e3f15d6d53355acae2d809e1a5c512115b0dc diff --git a/mpd.py b/mpd.py index 380f5b1..b87891b 100644 --- a/mpd.py +++ b/mpd.py @@ -269,9 +269,11 @@ class MPDClient(object): yield obj def _read_command_list(self): - for retval in self._command_list: - yield retval() - self._command_list = None + try: + for retval in self._command_list: + yield retval() + finally: + self._command_list = None self._fetch_nothing() def _iterator_wrapper(self, iterator): @@ -362,23 +364,23 @@ class MPDClient(object): flags = socket.AI_ADDRCONFIG except AttributeError: flags = 0 - msg = "getaddrinfo returns an empty list" + err = None for res in socket.getaddrinfo(host, port, socket.AF_UNSPEC, socket.SOCK_STREAM, socket.IPPROTO_TCP, flags): af, socktype, proto, canonname, sa = res + sock = None try: sock = socket.socket(af, socktype, proto) sock.connect(sa) - except socket.error, msg: - if sock: + return sock + except socket.error, err: + if sock is not None: sock.close() - sock = None - continue - break - if not sock: - raise socket.error(msg) - return sock + if err is not None: + raise err + else: + raise ConnectionError("getaddrinfo returns an empty list") def connect(self, host, port): if self._sock: