names = list()
for art in result.names:
if cls.database.get_bl_artist(art, add_not=True):
- cls.log.debug('Blacklisted "{0}"'.format(art))
+ cls.log.debug('Blacklisted "%s"', art)
continue
names.append(art)
if not names:
"search", "sticker find",]
track_obj = ['currentsong']
if self._comm in tracks_listing + track_obj:
- # pylint: disable=w0142
if isinstance(ans, list):
return [Track(**track) for track in ans]
elif isinstance(ans, dict):
self.log.info('Player: Initialising cache!')
self._cache = {'artists': frozenset(),
'nombid_artists': frozenset(),}
- self._cache['artists'] = frozenset(self._execute('list', ['artist']))
+ self._cache['artists'] = frozenset(filter(None, self._execute('list', ['artist'])))
if Artist.use_mbid:
- self._cache['nombid_artists'] = frozenset(self._execute('list', ['artist', 'musicbrainz_artistid', '']))
+ self._cache['nombid_artists'] = frozenset(filter(None, self._execute('list', ['artist', 'musicbrainz_artistid', ''])))
@blacklist(track=True)
def find_track(self, artist, title=None):
# look for exact search w/ musicbrainz_artistid
exact_m = self._execute('list', ['artist', 'musicbrainz_artistid', artist.mbid])
if exact_m:
- [artist.add_alias(name) for name in exact_m]
+ _ = [artist.add_alias(name) for name in exact_m]
found = True
else:
artist = Artist(name=artist.name)
if password:
try:
self._client.password(password)
-
- # Catch errors with the password command (e.g., wrong password)
- except CommandError as err:
- raise PlayerError("Could not connect to '%s': "
- "password command failed: %s" %
- (host, err))
-
- # Catch all other possible errors
except (MPDError, IOError) as err:
- raise PlayerError("Could not connect to '%s': "
- "error with password command: %s" %
- (host, err))
+ raise PlayerError("Could not connect to '%s': %s", (host, err))
# Controls we have sufficient rights
needed_cmds = ['status', 'stats', 'add', 'find', \
'search', 'currentsong', 'ping']
self.log.info(self._client.tagtypes())
self.log.warning('Disabling MusicBrainzIdentifier')
Artist.use_mbid = False
+ else:
+ self.log.trace('Available metadata: %s', self._client.tagtypes()) # pylint: disable=no-member
else:
self.log.warning('Use of MusicBrainzIdentifier disabled!')
self.log.info('Consider using MusicBrainzIdentifier for your music library')