Mainly use literal for list/dict and f-strings when possible

[mpd-sima.git] / sima / lib / track.py

diff --git a/sima/lib/track.py b/sima/lib/track.py
index f25d86d94496ca9e1d297a5ed1eb325c926f030e..2df220cc849811e48ac95e342302f4a7257cbdf5 100644 (file)
--- a/sima/lib/track.py
+++ b/sima/lib/track.py
@@ -39,7 +39,7 @@ class Track:
     """
 
     def __init__(self, file=None, duration=0, pos=-1, **kwargs):
-        self.title = self.artist = self.album = self.albumartist = ''
+        self.title = self.artist = self.album = self.albumartist = self.genre = ''
         self.musicbrainz_artistid = self.musicbrainz_albumartistid = None
         self.musicbrainz_albumid = self.musicbrainz_trackid = None
         self.pos = int(pos)
@@ -54,7 +54,7 @@ class Track:
                                  'musicbrainz_artistid',
                                  'musicbrainz_albumartistid']
         # Which tags have been collapsed?
-        self.collapsed_tags = list()
+        self.collapsed_tags = []
         # Needed for multiple tags which returns a list instead of a string
         self._collapse_tags()
 
@@ -117,7 +117,8 @@ class Track:
 
     @property
     def length(self):
-        """Get a fancy duration as ``%H:%M:%S`` (use :attr:`duration` to get duration in second only)"""
+        """Get a fancy duration as ``%H:%M:%S`` (use :attr:`duration` to get
+        duration in second only)"""
         temps = time.gmtime(self.duration)  # TODO: returns a date not a duration
         if temps.tm_hour:
             fmt = '%H:%M:%S'
@@ -133,7 +134,7 @@ class Track:
         * when genre tag is multivalued
         * when single tag uses coma or semi-colon separator
         """
-        if 'genre' not in self.__dict__:
+        if not self.genre:
             return []
         genres = self.genre.split(SEPARATOR)
         for sep in [',', ';']: