X-Git-Url: https://git.kaliko.me/?a=blobdiff_plain;f=sima%2Fmpdclient.py;h=0e7988b10f49b705ce14daa15334b7d27f680816;hb=d65f7a21478d3edde074d83e4b07a3650486c4b9;hp=c4ebadeaa7e1d4453aa92d8bbda5830c0715842e;hpb=94c7b5c9c88a414afd30aa91b133afec6f3c4b6a;p=mpd-sima.git diff --git a/sima/mpdclient.py b/sima/mpdclient.py index c4ebade..0e7988b 100644 --- a/sima/mpdclient.py +++ b/sima/mpdclient.py @@ -23,7 +23,7 @@ from logging import getLogger from select import select # external module -from musicpd import MPDClient, MPDError +from musicpd import MPDClient, MPDError as PlayerError # local import @@ -31,11 +31,6 @@ from .lib.meta import Meta, Artist, Album from .lib.track import Track from .lib.simastr import SimaStr from .utils.leven import levenshtein_ratio -from .utils.utils import MPDSimaException - - -class PlayerError(MPDSimaException): - """Fatal error in the player.""" # Some decorators @@ -130,8 +125,6 @@ class MPD(MPDClient): return super().__getattr__(cmd) except OSError as err: # socket errors raise PlayerError(err) from err - except MPDError as err: # hight level MPD client errors - raise PlayerError(err) from err def disconnect(self): """Overriding explicitly MPDClient.disconnect()""" @@ -161,7 +154,7 @@ class MPD(MPDClient): if password: try: self.password(password) - except (MPDError, OSError) as err: + except OSError as err: raise PlayerError(f"Could not connect to '{host}': {err}") from err # Controls we have sufficient rights available_cmd = self.commands() @@ -169,9 +162,9 @@ class MPD(MPDClient): if cmd not in available_cmd: self.disconnect() raise PlayerError(f'Could connect to "{host}", but command "{cmd}" not available') - self.tagtypes('clear') + self.tagtypes_clear() for tag in MPD.needed_tags: - self.tagtypes('enable', tag) + self.tagtypes_enable(tag) ltt = set(map(str.lower, self.tagtypes())) needed_tags = set(map(str.lower, MPD.needed_tags)) if len(needed_tags & ltt) != len(MPD.needed_tags): @@ -179,7 +172,7 @@ class MPD(MPDClient): self.log.warning('Tags needed: %s', needed_tags) raise PlayerError('Missing mandatory metadata!') for tag in MPD.needed_mbid_tags: - self.tagtypes('enable', tag) + self.tagtypes_enable(tag) # Controls use of MusicBrainzIdentifier if self.config.getboolean('sima', 'musicbrainzid'): ltt = set(self.tagtypes()) @@ -253,8 +246,6 @@ class MPD(MPDClient): self.noidle() except OSError as err: raise PlayerError(err) from err - except MPDError as err: # hight level MPD client errors - raise PlayerError(err) from err def clean(self): """Clean blocking event (idle) and pending commands