From: kaliko <kaliko@azylum.org>
Date: Fri, 28 Oct 2022 07:06:02 +0000 (+0200)
Subject: Revert "Catch uncaught socket.timeout (OSError subclass)."
X-Git-Tag: 0.18.2~1
X-Git-Url: https://git.kaliko.me/?a=commitdiff_plain;ds=inline;h=7bea847c83c3da1f2f465cfb672e14495dd74d20;p=mpd-sima.git

Revert "Catch uncaught socket.timeout (OSError subclass)."

This reverts commit 36db5e965f1e8dba54b42e31082709b914dd5194.

As mention in #63, this patch does not fixed the issue.
---

diff --git a/sima/mpdclient.py b/sima/mpdclient.py
index cced48c..b50df91 100644
--- a/sima/mpdclient.py
+++ b/sima/mpdclient.py
@@ -189,13 +189,7 @@ class MPD(MPDClient):
             self.log.warning('Use of MusicBrainzIdentifier disabled!')
             self.log.info('Consider using MusicBrainzIdentifier for your music library')
             self.use_mbid = Meta.use_mbid = False
-        # TODO: Why do I need to intercept OSError here?
-        # why is it not wrapped in PlayerError in __getattr__?
-        # (cf. commit message for more)
-        try:
-            self._reset_cache()
-        except OSError as err:
-            raise PlayerError(f'Error during cache init: {err}') from err
+        self._reset_cache()
     # ######### / Overriding MPDClient #########
 
     def _reset_cache(self):