From: Kaliko Jack <kaliko@azylum.org>
Date: Fri, 19 Feb 2021 14:50:44 +0000 (+0100)
Subject: Document fileno method
X-Git-Tag: v0.6.0~8
X-Git-Url: https://git.kaliko.me/?a=commitdiff_plain;h=bbb80ee761838dce989b3584a75fd26b53dcd9ce;p=python-musicpd.git

Document fileno method

Also add comment about probable useless ConnectionError raised
---

diff --git a/musicpd.py b/musicpd.py
index 9b1d51b..eeb4b9a 100644
--- a/musicpd.py
+++ b/musicpd.py
@@ -569,7 +569,7 @@ class MPDClient:
             obj['data'] = self._read_binary(amount)
         except IOError as err:
             raise ConnectionError('Error reading binary content: %s' % err)
-        if len(obj['data']) != amount:
+        if len(obj['data']) != amount:  # can we ever get there?
             raise ConnectionError('Error reading binary content: '
                       'Expects %sB, got %s' % (amount, len(obj['data'])))
         # Fetches trailing new line
@@ -709,6 +709,9 @@ class MPDClient:
         self._reset()
 
     def fileno(self):
+        """Return the socket’s file descriptor (a small integer).
+        This is useful with :py:obj:`select.select`.
+        """
         if self._sock is None:
             raise ConnectionError("Not connected")
         return self._sock.fileno()