]> kaliko git repositories - mpd-sima.git/log
mpd-sima.git
2 years agoReleasing 0.18.0 0.18.0
kaliko [Tue, 16 Nov 2021 15:57:23 +0000 (16:57 +0100)]
Releasing 0.18.0

2 years agoFixed help message typo
kaliko [Tue, 16 Nov 2021 15:42:58 +0000 (16:42 +0100)]
Fixed help message typo

2 years agoRemove obsolete simadb_cli
kaliko [Tue, 16 Nov 2021 15:32:32 +0000 (16:32 +0100)]
Remove obsolete simadb_cli

2 years agoAdd some space padding in log format
kaliko [Tue, 16 Nov 2021 14:39:42 +0000 (15:39 +0100)]
Add some space padding in log format

Allows to align debug log message with mpdclient.py file

2 years agoMore robust Tags plugin MPD filter configuration
kaliko [Tue, 16 Nov 2021 14:24:52 +0000 (15:24 +0100)]
More robust Tags plugin MPD filter configuration

Remove external enclosing parentheses in user defined MPD filter, for
instance when there is more than one expression:
    ((genre == 'rock' ) AND (date =~ '198.')).

Even though it's a valid MPD filter, forge_filter will enclose it
properly. We do not want to through a syntax error at users since it's a
valid MPD filter, hence trying to transparently reformat the filter.

filter = ((genre == 'rock' ) AND (date =~ '198.'))

  and

filter = (genre == 'rock' ) AND (date =~ '198.')

Will work the same, producing the valid MPD filter:

    ((genre == 'Punk') AND (date =~ '198[2-9]+') AND (artist != ''))

2 years agoFixed wrong use of musicpd for tagtypes command (Closes #60)
kaliko [Tue, 16 Nov 2021 13:32:18 +0000 (14:32 +0100)]
Fixed wrong use of musicpd for tagtypes command (Closes #60)

2 years agoCleanup code
kaliko [Tue, 16 Nov 2021 10:52:04 +0000 (11:52 +0100)]
Cleanup code

Update Exceptions (cf. 3b4178f)
Add copyright header
Better error message

2 years agoRevert previous refactoring around Exceptions
kaliko [Tue, 16 Nov 2021 10:23:42 +0000 (11:23 +0100)]
Revert previous refactoring around Exceptions

Mainly 774e755 and part of 94c7b5c

PlayerError is musicpd.MPDError a different family of exceptions not to
be merged in MPDSimaException, as initially implemented in a978d29.

2 years agoman: Fixed and build mpd_sima.cfg.5 manual
kaliko [Sun, 14 Nov 2021 18:13:41 +0000 (19:13 +0100)]
man: Fixed and build mpd_sima.cfg.5 manual

2 years agoUpdate bash completion (Closes #61)
kaliko [Sun, 7 Nov 2021 17:16:21 +0000 (18:16 +0100)]
Update bash completion (Closes #61)

2 years agoCheck Tags config onmy when it is configured as internal plugin
kaliko [Sun, 7 Nov 2021 17:15:00 +0000 (18:15 +0100)]
Check Tags config onmy when it is configured as internal plugin

2 years agoFixed unhandled exception in monitor (idle MPD command)
kaliko [Fri, 29 Oct 2021 11:55:15 +0000 (13:55 +0200)]
Fixed unhandled exception in monitor (idle MPD command)

Socket timeout was handled but musicpd exception raised on server lost
was not. For instance ConnectionError: "Connection lost while reading
line" was not catch.

2 years agoci: Add missing dependencies
kaliko [Mon, 25 Oct 2021 09:29:24 +0000 (11:29 +0200)]
ci: Add missing dependencies

2 years agoCatch forgotten exception in mpdclient (Closes #59)
kaliko [Mon, 25 Oct 2021 09:20:01 +0000 (11:20 +0200)]
Catch forgotten exception in mpdclient (Closes #59)

2 years agoMainly use literal for list/dict and f-strings when possible
kaliko [Sat, 2 Oct 2021 13:23:04 +0000 (15:23 +0200)]
Mainly use literal for list/dict and f-strings when possible

2 years agoBig cleanup, pyling warning, style, error
kaliko [Sat, 2 Oct 2021 11:11:10 +0000 (13:11 +0200)]
Big cleanup, pyling warning, style, error

2 years agoInit genre attribute in Track object
kaliko [Sat, 2 Oct 2021 11:09:51 +0000 (13:09 +0200)]
Init genre attribute in Track object

2 years agoSome refactoring around Exceptions
kaliko [Sat, 2 Oct 2021 11:09:01 +0000 (13:09 +0200)]
Some refactoring around Exceptions

2 years agoSimplified first loop iteration detection
kaliko [Sat, 2 Oct 2021 10:50:03 +0000 (12:50 +0200)]
Simplified first loop iteration detection

2 years agoClean some linter warnings and errors
kaliko [Fri, 1 Oct 2021 18:29:57 +0000 (20:29 +0200)]
Clean some linter warnings and errors

2 years agoci: Fixed unittest
kaliko [Thu, 30 Sep 2021 18:02:47 +0000 (20:02 +0200)]
ci: Fixed unittest

2 years agoci: Fixed unittest
kaliko [Thu, 30 Sep 2021 17:52:25 +0000 (19:52 +0200)]
ci: Fixed unittest

2 years agoDeal with lost connection (Closes #53)
kaliko [Thu, 30 Sep 2021 17:15:10 +0000 (19:15 +0200)]
Deal with lost connection (Closes #53)

2 years agoAdd more info in crash report (Closes #56)
kaliko [Thu, 30 Sep 2021 17:03:51 +0000 (19:03 +0200)]
Add more info in crash report (Closes #56)

2 years agoUpdate dead http link
kaliko [Thu, 30 Sep 2021 13:19:43 +0000 (15:19 +0200)]
Update dead http link

2 years agoConfigure SAST in
kaliko [Fri, 23 Jul 2021 14:17:32 +0000 (16:17 +0200)]
Configure SAST in

2 years agoMore robust MPD client (start addressing #53)
kaliko [Mon, 5 Jul 2021 08:19:58 +0000 (10:19 +0200)]
More robust MPD client (start addressing #53)

This actually closes the issue but I believe the client does not
currently detect half-opened connection, for instance router
reboot|crash|host roaming.

2 years agoCleanup Exceptions
kaliko [Sun, 4 Jul 2021 17:26:15 +0000 (19:26 +0200)]
Cleanup Exceptions

2 years agoFixed crash when player.search_track returns nothing
kaliko [Tue, 29 Jun 2021 07:44:22 +0000 (09:44 +0200)]
Fixed crash when player.search_track returns nothing

2 years agoFixed double quote error, missing escape character (Closes #52)
kaliko [Fri, 18 Jun 2021 10:38:06 +0000 (12:38 +0200)]
Fixed double quote error, missing escape character (Closes #52)

2 years agoFixed crash when player.find_tracks returns nothing
kaliko [Thu, 17 Jun 2021 11:48:57 +0000 (13:48 +0200)]
Fixed crash when player.find_tracks returns nothing

With the block list, player.find_tracks might return an empty list.

2 years agoRemove to_add attibute
kaliko [Thu, 17 Jun 2021 11:46:53 +0000 (13:46 +0200)]
Remove to_add attibute

2 years agoMPD client: Tries to resolve MusicBrainzArtistID when possible (fixed b36c71a)
kaliko [Tue, 8 Jun 2021 18:39:15 +0000 (20:39 +0200)]
MPD client: Tries to resolve MusicBrainzArtistID when possible (fixed b36c71a)

2 years agodoc: Update docstrings
kaliko [Tue, 8 Jun 2021 15:12:04 +0000 (17:12 +0200)]
doc: Update docstrings

2 years agoMPD client: Tries to resolve MusicBrainzArtistID when possible.
kaliko [Tue, 8 Jun 2021 14:46:40 +0000 (16:46 +0200)]
MPD client: Tries to resolve MusicBrainzArtistID when possible.

2 years agoPlayerError inherit from MPDError instead of plain Exception
kaliko [Tue, 8 Jun 2021 14:30:01 +0000 (16:30 +0200)]
PlayerError inherit from MPDError instead of plain Exception

2 years agoBetter debug message, complete a comment
kaliko [Tue, 8 Jun 2021 11:34:46 +0000 (13:34 +0200)]
Better debug message, complete a comment

2 years agoUse Track Album attribute to avoid missing album name
kaliko [Mon, 7 Jun 2021 19:02:09 +0000 (21:02 +0200)]
Use Track Album attribute to avoid missing album name

Track.Album as a fallback is name is not provided.

2 years agoFixed bad implementation of blocklist for albums
kaliko [Mon, 7 Jun 2021 13:09:06 +0000 (15:09 +0200)]
Fixed bad implementation of blocklist for albums

2 years agodoc: Update docstrings
kaliko [Mon, 7 Jun 2021 12:34:14 +0000 (14:34 +0200)]
doc: Update docstrings

2 years agoman: Fixed error in XDG env. var.
kaliko [Mon, 7 Jun 2021 12:31:29 +0000 (14:31 +0200)]
man: Fixed error in XDG env. var.

2 years agoFixed issue with multivalued musicbrainz_artistid (Closes #47)
kaliko [Mon, 7 Jun 2021 12:28:32 +0000 (14:28 +0200)]
Fixed issue with multivalued musicbrainz_artistid (Closes #47)

2 years agoUpdate Changelog
kaliko [Sat, 5 Jun 2021 05:43:06 +0000 (07:43 +0200)]
Update Changelog

2 years agoUpdate Changelog, end sqlite rewrite phase (closes #45, #49, #33)
kaliko [Fri, 4 Jun 2021 17:27:44 +0000 (19:27 +0200)]
Update Changelog, end sqlite rewrite phase (closes #45, #49, #33)

2 years agosimadb: More consistent use of albumartist info in fetch_albums_history
kaliko [Fri, 4 Jun 2021 14:22:09 +0000 (16:22 +0200)]
simadb: More consistent use of albumartist info in fetch_albums_history

fetch_albums_history() returns a list of Album objects with an Artist
attribute set to albumartist (if provided, else falls back to artist).
We want an Album view of history.

fetch_albums_history(needle) returns a list of Album objects with
Artist attribute set to artist (in this case we want album played for
artist == needle). Here we want the artist view on album history.

2 years agosimadb: Fixed timezone, record play timestamp as UTC (Closes #51)
kaliko [Fri, 4 Jun 2021 14:18:18 +0000 (16:18 +0200)]
simadb: Fixed timezone, record play timestamp as UTC (Closes #51)

Convert all utcnow() to now(timezone.utc)

2 years agoUse MusicBrainz_albumid for album search (Closes #30)
kaliko [Fri, 4 Jun 2021 09:18:56 +0000 (11:18 +0200)]
Use MusicBrainz_albumid for album search (Closes #30)

2 years agoRewrote blocklist feature with the new simadb API
kaliko [Thu, 3 Jun 2021 14:36:48 +0000 (16:36 +0200)]
Rewrote blocklist feature with the new simadb API

2 years agoImproved filter_track plugin method
kaliko [Thu, 3 Jun 2021 09:01:06 +0000 (11:01 +0200)]
Improved filter_track plugin method

2 years agosimadb: Expose file in view_bl
kaliko [Thu, 3 Jun 2021 08:57:24 +0000 (10:57 +0200)]
simadb: Expose file in view_bl

It permits to build a Track object for comparison

2 years agoArtist object changes
kaliko [Wed, 2 Jun 2021 16:08:03 +0000 (18:08 +0200)]
Artist object changes

Use name for albumartist if albumartist is not provided.

2 years agoAdd Album property to Track objects
kaliko [Wed, 2 Jun 2021 15:41:40 +0000 (17:41 +0200)]
Add Album property to Track objects

2 years agoDo not limit valid UUID to version 4
kaliko [Wed, 2 Jun 2021 15:31:16 +0000 (17:31 +0200)]
Do not limit valid UUID to version 4

3 years agosimadb: Fixed early connection close
kaliko [Mon, 10 May 2021 09:05:14 +0000 (11:05 +0200)]
simadb: Fixed early connection close

3 years agoUpdate manual
kaliko [Sun, 9 May 2021 16:17:34 +0000 (18:17 +0200)]
Update manual

3 years agosimadb: Propagate add option
kaliko [Sun, 9 May 2021 09:55:35 +0000 (11:55 +0200)]
simadb: Propagate add option

3 years agoAdd blocklist commands, remove simadb_cli
kaliko [Sun, 9 May 2021 09:48:57 +0000 (11:48 +0200)]
Add blocklist commands, remove simadb_cli

Move all command to a subparser

3 years agoMPD client: Remove useless check on use_mbid
kaliko [Thu, 6 May 2021 09:32:29 +0000 (11:32 +0200)]
MPD client: Remove useless check on use_mbid

3 years agoUse os.getenv instead of os.environ.get
kaliko [Wed, 5 May 2021 18:20:01 +0000 (20:20 +0200)]
Use os.getenv instead of os.environ.get

3 years agoAdd abstract unix socket support for MPD connection
kaliko [Wed, 5 May 2021 16:30:45 +0000 (18:30 +0200)]
Add abstract unix socket support for MPD connection

Add unittests for env var parsing

3 years agoFixed test_config
kaliko [Wed, 5 May 2021 15:58:12 +0000 (17:58 +0200)]
Fixed test_config

568365b introduced a file acces control on db_file

3 years agosimadb: do not fetch NULL genre
kaliko [Tue, 4 May 2021 18:37:34 +0000 (20:37 +0200)]
simadb: do not fetch NULL genre

3 years agoAdd new database replacement code.
kaliko [Tue, 4 May 2021 18:21:13 +0000 (20:21 +0200)]
Add new database replacement code.

In case a previous database is loaded, it is renamed with a prefix
"-old-version-backup" in the same directory. No migration managed.

3 years agoUpdate simadb API
kaliko [Tue, 4 May 2021 13:37:44 +0000 (15:37 +0200)]
Update simadb API

3 years agoUpdate file access controls
kaliko [Tue, 4 May 2021 13:15:53 +0000 (15:15 +0200)]
Update file access controls

3 years agoUse new sqlite module
kaliko [Mon, 3 May 2021 11:40:49 +0000 (13:40 +0200)]
Use new sqlite module

3 years agoAdd genres tables to the database, update Genre plugin (related to #48)
kaliko [Mon, 3 May 2021 07:41:14 +0000 (09:41 +0200)]
Add genres tables to the database, update Genre plugin (related to #48)

3 years agoUpdate simadb API
kaliko [Sat, 1 May 2021 17:13:53 +0000 (19:13 +0200)]
Update simadb API

3 years agoAdd fetch history methods
kaliko [Sat, 1 May 2021 13:28:37 +0000 (15:28 +0200)]
Add fetch history methods

3 years agoAdd Triggers for blocklist→albums|artists
kaliko [Fri, 30 Apr 2021 09:35:59 +0000 (11:35 +0200)]
Add Triggers for blocklist→albums|artists

3 years agoFixed indentation
kaliko [Fri, 30 Apr 2021 08:02:30 +0000 (10:02 +0200)]
Fixed indentation

3 years agoAdd drop_all, fetch_artists*, get_bl_* methods
kaliko [Thu, 29 Apr 2021 14:03:27 +0000 (16:03 +0200)]
Add drop_all, fetch_artists*, get_bl_* methods

3 years agoRewrote simadb
kaliko [Wed, 28 Apr 2021 11:06:36 +0000 (13:06 +0200)]
Rewrote simadb

3 years agoci: Exposes unittest report to gitlab
kaliko [Wed, 5 May 2021 11:55:27 +0000 (13:55 +0200)]
ci: Exposes unittest report to gitlab

3 years agoFixed crash when setting XDG_CONFIG_HOME (closes #50)
kaliko [Wed, 5 May 2021 14:33:28 +0000 (16:33 +0200)]
Fixed crash when setting XDG_CONFIG_HOME (closes #50)

Also add unittests for XDG env. var. management.

3 years agoRemove dead code
kaliko [Sat, 1 May 2021 17:15:12 +0000 (19:15 +0200)]
Remove dead code

3 years agoCleanup obsolete code (ralated to 6194c3a)
kaliko [Fri, 30 Apr 2021 08:04:10 +0000 (10:04 +0200)]
Cleanup obsolete code (ralated to 6194c3a)

3 years agoFixed bug introduced in 6194c3a
kaliko [Thu, 29 Apr 2021 14:38:23 +0000 (16:38 +0200)]
Fixed bug introduced in 6194c3a

DB was not created when missing on startup.

3 years agoAdd missing command in bash completion
kaliko [Thu, 29 Apr 2021 14:37:49 +0000 (16:37 +0200)]
Add missing command in bash completion

3 years agoRemoved obsolete CLI options
kaliko [Wed, 28 Apr 2021 16:02:39 +0000 (18:02 +0200)]
Removed obsolete CLI options

3 years agoRemove HTML files
kaliko [Wed, 28 Apr 2021 15:51:41 +0000 (17:51 +0200)]
Remove HTML files

3 years agoBump version
kaliko [Wed, 28 Apr 2021 15:50:27 +0000 (17:50 +0200)]
Bump version

3 years agoReleasing 0.17.0 0.17.0
kaliko [Wed, 28 Apr 2021 15:36:29 +0000 (17:36 +0200)]
Releasing 0.17.0

3 years agoAdd support of musicbrainz_{albumid,trackid} in Track object
kaliko [Wed, 28 Apr 2021 11:00:13 +0000 (13:00 +0200)]
Add support of musicbrainz_{albumid,trackid} in Track object

3 years agoAdd new command purge-history
kaliko [Fri, 23 Apr 2021 09:23:03 +0000 (11:23 +0200)]
Add new command purge-history

3 years agoUpdate bash completion (closes #44)
kaliko [Fri, 23 Apr 2021 08:53:03 +0000 (10:53 +0200)]
Update bash completion (closes #44)

3 years agoAesthetic changes in usage messages
kaliko [Fri, 23 Apr 2021 08:36:18 +0000 (10:36 +0200)]
Aesthetic changes in usage messages

3 years agoFixed Genre plugin documenation
kaliko [Thu, 22 Apr 2021 13:17:00 +0000 (15:17 +0200)]
Fixed Genre plugin documenation

3 years agoAdd new command (closes #43)
kaliko [Thu, 22 Apr 2021 13:15:15 +0000 (15:15 +0200)]
Add new command (closes #43)

Add config-test, create-db, generate-config

3 years agoExtract Tags control_config method from plugin
kaliko [Wed, 21 Apr 2021 13:31:55 +0000 (15:31 +0200)]
Extract Tags control_config method from plugin

Ease reuse outside of plugin

3 years agoExpose only config in MPDClient instance.
kaliko [Wed, 21 Apr 2021 12:28:36 +0000 (14:28 +0200)]
Expose only config in MPDClient instance.

Remove useless daemon argument

3 years agoDefault config definition more consistent
kaliko [Wed, 21 Apr 2021 10:17:40 +0000 (12:17 +0200)]
Default config definition more consistent

3 years agosetup.py: Remove useless import
kaliko [Tue, 20 Apr 2021 08:42:02 +0000 (10:42 +0200)]
setup.py: Remove useless import

3 years agoAdd Genre plugin
kaliko [Mon, 19 Apr 2021 16:59:31 +0000 (18:59 +0200)]
Add Genre plugin

3 years agoFixed manual for Tags plugin
kaliko [Mon, 19 Apr 2021 15:40:53 +0000 (17:40 +0200)]
Fixed manual for Tags plugin

3 years agoUse duration instead of time in Track objects (closes #37)
kaliko [Mon, 19 Apr 2021 15:17:13 +0000 (17:17 +0200)]
Use duration instead of time in Track objects (closes #37)

3 years agoFixed bad pid in Uniq core plugin (closes #32)
kaliko [Mon, 19 Apr 2021 14:38:12 +0000 (16:38 +0200)]
Fixed bad pid in Uniq core plugin (closes #32)

When daemonized the PID advertised by the plugin (channel's name) was
the PID before the double fork and not the actual daemon's PID.

3 years agoFixed examples
kaliko [Mon, 19 Apr 2021 13:55:31 +0000 (15:55 +0200)]
Fixed examples

3 years agoFixed variable in info log message (typo introduced in baa6dc7)
kaliko [Sun, 21 Feb 2021 16:34:42 +0000 (17:34 +0100)]
Fixed variable in info log message (typo introduced in baa6dc7)

3 years agoExposes genres in Track objets
kaliko [Sat, 20 Feb 2021 16:22:14 +0000 (17:22 +0100)]
Exposes genres in Track objets